| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Perform streaming logical transactions by background workers and parallel apply |
| Date: | 2022-08-19 03:24:47 |
| Message-ID: | CAA4eK1+TJrfqm4mKfaGX1Ny=k_9DwS2-ZfHxNdwj62ZhDLsxiQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 19, 2022 at 4:36 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Wang-san,
>
> Here is some more information about my v21-0001 review [2] posted yesterday.
>
> ~~
>
> If the streaming=parallel will be disallowed for publishers not using
> protocol 4 (see Amit's post [1]), then please ignore all my previous
> review comments about the protocol descriptions (see [2] comments #4b,
> #7b, #47a, #47b).
>
> ~~
>
> Also, I was having second thoughts about the name replacement for the
> 'main_worker_pid' member (see [2] comments #1b, #49). Previously I
> suggested 'apply_leader_pid', but now I think something like
> 'apply_bgworker_leader_pid' would be better. (It's a bit verbose, but
> now it gives the proper understanding that only an apply bgworker can
> have a valid value for this member).
>
I find your previous suggestion to name it 'apply_leader_pid' better.
According to me, it conveys the meaning.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-08-19 03:30:05 | Re: Cleaning up historical portability baggage |
| Previous Message | Justin Pryzby | 2022-08-19 02:33:56 | Re: Mingw task for Cirrus CI |