Re: Add \i option to bring in the specified file as a quoted literal

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Piotr Marcinczyk <pmarcinc(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add \i option to bring in the specified file as a quoted literal
Date: 2013-11-13 03:28:07
Message-ID: CAA4eK1+SgupKf1bdocCrrkV-CMhcGeT89x1LG6MgQpHU_Hphvg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 12, 2013 at 9:37 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Wed, Oct 23, 2013 at 10:31:39AM +0530, Amit Kapila wrote:
>> On Tue, Oct 22, 2013 at 3:04 AM, Piotr Marcinczyk <pmarcinc(at)gmail(dot)com> wrote:
>> > Hi,
>> >
>> > I would like to implement item from TODO marked as easy: "Add \i option
>> > to bring in the specified file as a quoted literal". I understand intent
>> > of this item, to be able to have parts of query written in separate
>> > files (now it is impossible, because \i tries to execute content of file
>> > as a separate command by function process_file).
>>
>> For the usecase discussed in the mail chain of that TODO item, Robert
>> Haas has provided an alternative to achieve it, please check below
>> link:
>> http://www.postgresql.org/message-id/AANLkTi=7C8xFYF7uQW0y+si8oNdKoY2NX8jc4bU0GWvY@mail.gmail.com
>>
>> If you think that alternative is not sufficient for the use case, then
>> adding new option/syntax is worth, otherwise it might be a shortcut or
>> other form of some existing way which can be useful depending on how
>> frequently users use this syntax.
>
> So, can we remove this TODO item?
TODO item is created before Robert Haas has provided an alternative
way to achieve the same thing. In some cases there are multiple ways
to
achieve the same thing (example: shortcut options in psql) if it is
used quite frequently and people want some easy way of doing it. In
this case I
don't think this is used frequently, so I don't see the need of
doing it. We should remove this TODO item.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-11-13 03:34:40 Re: Clang 3.3 Analyzer Results
Previous Message Peter Eisentraut 2013-11-13 03:22:20 [PATCH] ecpg: Split off mmfatal() from mmerror()