| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Perform streaming logical transactions by background workers and parallel apply |
| Date: | 2022-08-19 09:10:46 |
| Message-ID: | CAA4eK1+SNa5STONx48Uy+K4hVyh3DbHknCjMUOwhHcHjTL2_gA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 19, 2022 at 2:36 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Here are my review comments for the v23-0005 patch:
>
> ======
>
> Commit Message says:
> main_worker_pid is Process ID of the main apply worker, if this process is a
> apply background worker. NULL if this process is a main apply worker or a
> synchronization worker.
> The new column can make it easier to distinguish main apply worker and apply
> background worker.
>
> --
>
> Having a column called ‘main_worker_pid’ which is defined to be NULL
> if the process *is* the main apply worker does not make any sense to
> me.
>
I haven't read this part of a patch but it seems to me we have
something similar for parallel query workers. Refer 'leader_pid'
column in pg_stat_activity.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2022-08-19 09:35:03 | Re: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Peter Smith | 2022-08-19 09:06:14 | Re: Perform streaming logical transactions by background workers and parallel apply |