Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Amit Kapila <akapila(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.
Date: 2022-09-07 03:46:54
Message-ID: CAA4eK1+S7h2Tp6hWuEXyVNNrBNeO91pxJNSp3NmNL34FxHZbbQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Sep 6, 2022 at 7:40 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> > > I think they should say something like
> > >
> > > "logical replication starts skipping transaction with LSN %X/%X"
> > > "logical replication completed skipping transaction with LSN %X/%X"
> > >
> >
> > This looks better to me.
>
> +1
>
> > If you find the above argument to
> > differentiate between the start and end LSN convincing then we can
> > think of replacing "with" in the above messages with "finished at". I
> > see your point related to using "finished at" for PREPARE may not be a
> > good idea but I don't have better ideas for the same.
>
> Given that the user normally doesn't need to be aware of the
> difference between start LSN and end LSN in the context of using this
> feature, I think we can use "with LSN %X/%X".
>

Fair enough.

Alvaro, would you like to push your proposed change? Otherwise, I am
happy to take care of this.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2022-09-07 03:47:21 pgsql: Make more effort to put a sentinel at the end of allocated memor
Previous Message Amit Kapila 2022-09-07 03:41:17 pgsql: Doc: Explain about Column List feature.

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2022-09-07 04:13:37 Re: Reducing the chunk header sizes on all memory context types
Previous Message Amit Kapila 2022-09-07 03:41:17 pgsql: Doc: Explain about Column List feature.