| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Follow-up review items for update_deleted |
| Date: | 2026-09-09 05:05:10 |
| Message-ID: | CAA4eK1+OWm7qByomi5q+_fUg8W2yJzq6FhW82j3gS7DE2YOs2Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 8, 2026 at 9:52 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> In added test we tried to assign a transaction ID then ensure xmin of the slot
> can be smaller. However, since query_until() could return before starting a new
> transaction, there was a case that $next_xid cannot be computed correctly.
> IIUC query_safe() returns after running all the command and it should be used here.
> Also, I found another unnecessary usage of query_until(), it's also fixed.
>
> Please see attached to fix the issue. This must be backpatched to PG19 and
> attached could be applied.
>
Thanks for the analysis and patch, it looked good to me. Pushed.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-09-09 05:23:35 | Re: pgbench: \gset and \aset should store SQL NULL as the null value |
| Previous Message | Hüseyin Demir | 2026-09-09 05:00:17 | Re: [PATCH] Report changes discarded for relations not in the subscription |