Re: Added schema level support for publication.

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Subject: Re: Added schema level support for publication.
Date: 2021-09-06 08:18:57
Message-ID: CAA4eK1+NqQTDr9Y1SgjQ7SwwPCO9mvqaY642+MRbVdxpj_6kBQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 6, 2021 at 9:53 AM tanghy(dot)fnst(at)fujitsu(dot)com
<tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Thursday, September 2, 2021 2:36 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > On Wed, Sep 1, 2021 at 11:14 AM tanghy(dot)fnst(at)fujitsu(dot)com
> > <tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
> > >
> > > 3. When using '\dn+', I noticed that the list of publications only contains the
> > > publications for "SCHEMA", "FOR ALL TABLES" publications are not shown. Is it
> > designed on purpose?
> > > (The result of '\d+' lists the publications of "SCHEAME" and "FOR ALL TABLES").
> > >
> > > For example:
> > > create schema sch1;
> > > create table sch1.tbl(a int);
> > > create publication pub_schema for all tables in schema sch1;
> > > create publication pub_all_tables for all tables;
> >
> > I'm not sure if it is intentional or not, Do you want to post the
> > question in a separate thread and see if that should be handled?
> >
>
> Sorry, maybe I didn't make my last question clearly enough.
>
> In HEAD(where schema level is not supported for publication), there is no publication
> information in the result of '\dn+'.
>
> With this schema patch, '\dn+' shows the publications related to the schema, but ALL
> TABLES publications are not shown. Do you think we should add ALL TABLES publications, too?
>

No, I don't think we need to display For All Tables publication under
\dn+. It is already shown with \d+ <table_name> command.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message houzj.fnst@fujitsu.com 2021-09-06 08:19:34 RE: [BUG] Unexpected action when publishing partition tables
Previous Message Ronan Dunklau 2021-09-06 08:16:21 Re: ORDER BY pushdowns seem broken in postgres_fdw