| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Support EXCEPT for TABLES IN SCHEMA publications |
| Date: | 2026-07-02 09:03:47 |
| Message-ID: | CAA4eK1+NmQRjSHPLr0X8YBuC6joivFqgsY3_qJ5-RnuuwNGkRQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 1, 2026 at 3:54 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
>
> On Wed, Jul 1, 2026 at 3:42 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> > During tests, I found one behavior that needs discussion:
> >
> > Consider a partition hierarchy where the root table is in schema s2, a
> > child partition is in schema s1, and the publication includes both
> > schemas but excludes only the root table.
>
> This is the exact scenario I had in mind when reviewing
> 'get_rel_sync_entry-->GetTopMostAncestorInPublication' flow, thus I
> suggested adding comments about intentionally fetching the 'Exclude
> list' only for the Root. I was about to test it in my next review
> cycle.
>
> The first thought is that if root is excluded, the partition should
> also be excluded to maintain consistency with the 'ALL TABLES Except
> ROOT' behaviour. But then it needs to be documented too.
>
+1. It is good to be consistent here with similar ALL TABLES case.
BTW, as we can't exclude the child table explicitly, this anyway seems
like the only option because otherwise, users won't have any way to
exclude the child table.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2026-07-02 09:11:35 | Re: Global temporary tables |
| Previous Message | John Naylor | 2026-07-02 09:00:43 | Re: [PATCH] Use ssup_datum_*_cmp for int2, oid, and oid8 sort support |