| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_stat_get_replication_slot and pg_stat_get_subscription_worker incorrectly marked as proretset |
| Date: | 2022-02-21 11:30:43 |
| Message-ID: | CAA4eK1+MSV1s-74q3nX5c-g4qtTmiWw91doKnWa3NjFJWo9KaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 21, 2022 at 4:56 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Feb 21, 2022 at 04:19:59PM +0530, Amit Kapila wrote:
> > On Mon, Feb 21, 2022 at 11:21 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >> Agreed.
> >>
> >
> > +1. How about attached?
>
> That's the same thing as what I sent upthread, so that's correct to
> me, except that I have fixed both functions :)
>
Sorry, I hadn't looked at your patch.
> You are not touching pg_stat_get_subscription_worker() because the
> plan is to revert it from HEAD? I have not followed the other
> discussion closely.
>
It is still under discussion. I'll take the necessary action along
with other things related to that view based on the conclusion on that
thread.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2022-02-21 12:00:54 | Re: set TESTDIR from perl rather than Makefile |
| Previous Message | Michael Paquier | 2022-02-21 11:26:26 | Re: pg_stat_get_replication_slot and pg_stat_get_subscription_worker incorrectly marked as proretset |