Re: About a recently-added message

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: shveta(dot)malik(at)gmail(dot)com, euler(at)eulerto(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: About a recently-added message
Date: 2024-02-19 05:40:38
Message-ID: CAA4eK1+MSDh3BsfgGKRggnM1L3K+aNXvug=V3HT-6L3v9g8sxA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 15, 2024 at 11:49 AM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> At Thu, 15 Feb 2024 09:22:23 +0530, shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote in
> >
> > +1 on changing the msg(s) suggested way. Please find the patch for the
> > same. It also removes double quotes around the variable names
>
> Thanks for the discussion.
>
> With a translator hat on, I would be happy if I could determine
> whether a word requires translation with minimal background
> information. In this case, a translator needs to know which values
> wal_level can take. It's relatively easy in this case, but I'm not
> sure if this is always the case. Therefore, I would be slightly
> happier if "logical" were double-quoted.
>

I see that we use "logical" in double quotes in various error
messages. For example: "wal_level must be set to \"replica\" or
\"logical\" at server start". So following that we can use the double
quotes here as well.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hayato Kuroda (Fujitsu) 2024-02-19 05:45:38 RE: speed up a logical replica setup
Previous Message Kyotaro Horiguchi 2024-02-19 05:34:26 Re: A new message seems missing a punctuation