Re: [PATCH] Add schema and table names to partition error

On Wed, Mar 4, 2020 at 10:48 AM Chris Bandy <bandy(dot)chris(at)gmail(dot)com> wrote:
>
> On 3/3/20 10:08 AM, Alvaro Herrera wrote:
> >> +\set VERBOSITY verbose
> >> +-- no partitions
> >> +CREATE TABLE pterr1 (x int, y int, PRIMARY KEY (x, y)) PARTITION BY RANGE (y);
> >> +INSERT INTO pterr1 VALUES (10, 10);
> >> +ERROR: 23514: no partition of relation "pterr1" found for row
> >> +DETAIL: Partition key of the failing row contains (y) = (10).
> >> +SCHEMA NAME: public
> >> +TABLE NAME: pterr1
> >> +LOCATION: ExecFindPartition, execPartition.c:349
> >
> > This won't work well, because people would be forced to update the .out
> > file whenever the execPartition.c file changed to add or remove lines
> > before the one with the error call.
>
> I agree. I expected that and should have made it more clear that I
> didn't intend for those tests to be committed. Others in the thread
> suggested I include some form of test, even if it didn't live past
> review.
>

Right, it is not for committing those tests, but rather once we try to
hit the code we are changing in this patch.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com