| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_upgrade and logical replication |
| Date: | 2023-09-20 11:24:36 |
| Message-ID: | CAA4eK1+J0Ki74WScoTC4mJSYn4mSOhgrRFcFMQ_OCV0bfXjWVg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 15, 2023 at 3:08 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> The attached v8 version patch has the changes for the same.
>
Is the check to ensure remote_lsn is valid correct in function
check_for_subscription_state()? How about the case where the apply
worker didn't receive any change but just marked the relation as
'ready'?
Also, the patch seems to be allowing subscription relations from PG
>=10 to be migrated but how will that work if the corresponding
publisher is also upgraded without slots? Won't the corresponding
workers start failing as soon as you restart the upgrade server? Do we
need to document the steps for users?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2023-09-20 11:28:33 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | Michael Paquier | 2023-09-20 11:24:05 | Re: persist logical slots to disk during shutdown checkpoint |