From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: list of TransactionIds |
Date: | 2022-05-16 02:28:37 |
Message-ID: | CAA4eK1+H-L9ddsfDJVgmFfSVgxnL2eD8FXj7W9rz+CSM7C9pmw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, May 15, 2022 at 5:05 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2022-May-14, Amit Kapila wrote:
>
> > On Sat, May 14, 2022 at 1:57 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> > >
> > > We didn't have any use of TransactionId as members of List, until
> > > RelationSyncEntry->streamed_txns was introduced (464824323e57, pg14).
> > > It's currently implemented as a list of int. This is not wrong at
> > > present, but it may soon be, and I'm sure it rubs some people the wrong
> > > way.
> > >
> > > But is the rubbing way wrong enough to add support for TransactionId in
> > > pg_list.h, including, say, T_XidList?
> >
> > +1. I don't know if we have a need for this at other places but I feel
> > it is a good idea to make its current use better.
>
> I hesitate to add this the day just before beta. This is already in
> pg14, so maybe it's not a big deal if pg15 remains the same for the time
> being. Or we can change it for beta2. Or we could just punt until
> pg16. Any preferences?
>
I prefer to do this for pg16 unless we see some bug due to this.
--
With Regards,
Amit Kapila.
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2022-05-16 02:34:41 | pgbench --partitions=0 |
Previous Message | osumi.takamichi@fujitsu.com | 2022-05-16 00:58:46 | RE: First draft of the PG 15 release notes |