Re: [HACKERS] parallel.c oblivion of worker-startup failures

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] parallel.c oblivion of worker-startup failures
Date: 2017-12-06 06:43:07
Message-ID: CAA4eK1+GG1t_TcNEg0TEEBehoW_EJSOMCD8sLSfmg=zt33Kmew@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 5, 2017 at 11:34 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Nov 29, 2017 at 12:11 AM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Fri, Oct 27, 2017 at 9:54 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>> The patch still applies (with some hunks). I have added it in CF [1]
>>> to avoid losing track.
>>>
>>> [1] - https://commitfest.postgresql.org/15/1341/
>>
>> This did not get reviews and the patch still applies. I am moving it to next CF.
>
> I'd like to break this into two patches, one to fix the general
> background worker problems and another to fix the problems specific to
> parallel query.
>
> The attached version extracts the two fixes for general background
> worker problems from Amit's patch and adjust the comments a bit more
> extensively than he did.
>

Looks good to me.

> Barring objections, I'll commit and
> back-patch this; then we can deal with the other part of this
> afterward.
>

Sure, I will rebase on top of the commit unless you have some comments
on the remaining part.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vitaliy Garnashevich 2017-12-06 07:06:52 Re: Bitmap scan is undercosted?
Previous Message sanyam jain 2017-12-06 06:36:36 Error bundling script file with extension when event trigger commands are used