| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: Cleaning up orphaned files using undo logs |
| Date: | 2019-07-31 04:43:26 |
| Message-ID: | CAA4eK1+E=NJ2kAOZBR9K7FTgYmM01aHwsybNizq28a0GtMDUNg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 30, 2019 at 5:26 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
>
> Hi Amit
>
> I've been testing some undo worker workloads (more on that soon),
>
One small point, there is one small bug in the error queues which is
that the element pushed into error queue doesn't have an updated value
of to_urec_ptr which is important to construct the hash key. This
will lead to undolauncher/worker think that the action for the same is
already processed and it removes the same from the hash table. I have
a fix for the same which I will share in next version of the patch
(which I am going to share in the next day or two).
> but
> here's a small thing: I managed to reach an LWLock self-deadlock in
> the undo worker launcher:
>
I could see the problem, will fix in next version.
Thank you for reviewing and testing this.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-07-31 04:48:23 | Re: Possible race condition in pg_mkdir_p()? |
| Previous Message | Michael Paquier | 2019-07-31 04:40:54 | Re: Possible race condition in pg_mkdir_p()? |