| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com> |
| Cc: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Subject: | Re: Allow logical replication to copy tables in binary format |
| Date: | 2023-03-15 05:33:49 |
| Message-ID: | CAA4eK1+C7ykvdBxh_t1BdbX5Da1bM1BgsE=-i2koPkd3pSid0A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 14, 2023 at 8:50 PM Takamichi Osumi (Fujitsu)
<osumi(dot)takamichi(at)fujitsu(dot)com> wrote:
>
> On Tuesday, March 14, 2023 8:02 PM Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> wrote:
> (3) copy_table()
>
> + /*
> + * If the publisher version is earlier than v14, it COPY command doesn't
> + * support the binary option.
> + */
>
> This sentence doesn't look correct grammatically. We can replace "it COPY command" with "subscription" for example. Kindly please fix it.
>
How about something like: "The binary option for replication is
supported since v14."?
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2023-03-15 05:54:32 | Re: Add macros for ReorderBufferTXN toptxn |
| Previous Message | Masahiko Sawada | 2023-03-15 05:13:24 | Re: Should vacuum process config file reload more often |