| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: In pageinspect, perform clean-up after testing gin-related functions |
| Date: | 2018-07-11 07:26:49 |
| Message-ID: | CAA4eK1+AP+FoeKj9yCBtZfQrOMztLLWhKyUnQ7vm_FBc_5r-AA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 11, 2018 at 12:37 PM, Kuntal Ghosh
<kuntalghosh(dot)2007(at)gmail(dot)com> wrote:
> Hello all,
>
> In pageinspect/sql/gin.sql, we don't drop the table test1 at the end
> of the test. IMHO, we should clean-up at the end of a test.
>
Yeah, it is good practice to drop the objects at the end. It is
strange that original commit adfb81d9e1 has this at the end of the
test, but a later commit 367b99bbb1 by Tom has removed the Drop
statement. AFAICS, this is just a silly mistake, but I might be
missing something. Tom, do you remember any reason for doing so? If
not, then I think we can revert back that change (aka commit Kuntal's
patch).
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-07-11 07:39:16 | Re: Problem with tupdesc in jsonb_to_recordset |
| Previous Message | Michael Paquier | 2018-07-11 07:16:47 | Re: TRUNCATE tables referenced by FKs on partitioned tables |