Re: why is PG_AUTOCONF_FILENAME is pg_config_manual.h?

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: why is PG_AUTOCONF_FILENAME is pg_config_manual.h?
Date: 2014-11-28 03:43:11
Message-ID: CAA4eK1+AOE1BqC7V=c35VWdvvTc9HZR8_T+Ao0C1OK7hM4aiag@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 27, 2014 at 8:28 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>
> Surely that's not a value that we expect users to be able to edit. Is
> pg_config_manual.h just abused as a place that's included everywhere?
>

Changing PG_AUTOCONF_FILENAME even by developer would
lead to loss of useful configuration settings (if any done by user via
ALTER SYSTEM) and on starting server user will see some
log message indicating that it has skipped processing configuration
file. I think the impact of changing this define is not so severe that
someone has to do initdb, however it's non-ignorable impact.

The file header of pg_config_manual.h seems to suggest that this
file contains such parameters.

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Rahila Syed 2014-11-28 04:30:44 Re: [REVIEW] Re: Compression of full-page-writes
Previous Message Kouhei Kaigai 2014-11-28 02:35:58 Re: no test programs in contrib