| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: RepOrigin vs. replorigin |
| Date: | 2026-01-27 11:02:22 |
| Message-ID: | CAA4eK1+9ugbGkN5SLz15KgMnf4BSU2Bu_1rKkd4h8ORH+BTCcQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 27, 2026 at 2:55 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> While reading the code in origin.c, I found the inconsistent use of
> RepOrigin and replorigin (with an 'l') quite confusing -- especially
> when trying to determine names for new functions or variables. For
> instance,
>
> - RepOriginId
> - InvalidRepOriginId
>
> - RM_REPLORIGIN_ID
> - XLOG_REPLORIGIN_{SET|DROP}
> - replorigin_session_origin
> - replorigin_session_xxx() functions
>
> Is there a conventional rule for choosing one over the other depending
> on context? Or should we consider unifying these naming conventions?"
>
AFAICS, most places use replorigin. So, +1 to unify the naming by
adding 'l' to places where it is not there unless someone sees a
theory/reason to keep them different.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2026-01-27 11:10:55 | Re: unnecessary executor overheads around seqscans |
| Previous Message | Antonin Houska | 2026-01-27 10:57:36 | Re: Adding REPACK [concurrently] |