Re: Parallel Index Scans

On Fri, Jan 20, 2017 at 7:29 AM, Haribabu Kommi
<kommi(dot)haribabu(at)gmail(dot)com> wrote:
>
> On Thu, Jan 19, 2017 at 1:18 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
>> >
>> > +extern BlockNumber _bt_parallel_seize(IndexScanDesc scan, bool
>> > *status);
>> > +extern void _bt_parallel_release(IndexScanDesc scan, BlockNumber
>> > scan_page);
>> >
>> > Any better names for the above functions, as these function will
>> > provide/set
>> > the next page that needs to be read.
>> >
>>
>> These functions also set the state of scan. IIRC, these names were
>> being agreed between Robert and Rahila as well (suggested offlist by
>> Robert). I am open to change if you or others have any better
>> suggestions.
>
>
> I didn't find any better names other than the following,
>
> _bt_get_next_parallel_page
> _bt_set_next_parallel_page
>

I am not sure using *_next_* here will convey the message because for
backward scans we set the last page. I am open to changing the names
of functions if committer and or others prefer the names suggested by
you.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com