Re: DOCS - ALTER PUBLICATION - description has confusing slash-list

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: DOCS - ALTER PUBLICATION - description has confusing slash-list
Date: 2026-08-11 03:19:52
Message-ID: CAA4eK1+3_ehkax0GiTPMefhBQ=ki6xWchwdDAji9EVbw-Hgqmg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 5, 2026 at 2:06 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> I noticed that the Description section of the ALTER PUBLICATION page
> [1] has a poorly worded sentence:
>
> "Note that adding tables/except tables/schemas to a publication that
> is already subscribed to will require an ALTER SUBSCRIPTION ...
> REFRESH PUBLICATION action"
>
> The problem is due to that strange slash-list. Apart from being
> difficult to read, it makes it sound as if there's a distinct object
> called an "except table", when what's meant is "changing a
> publication's EXCEPT list."
>
> PSA patch v1 to reword this using plain English.
>

LGTM. minot nitpic: "...publication. Note", here instead of two
spaces, let's use one space to be consistent with the nearby doc
wording. Also, this needs to be backpatched to 19, see if applied and
build cleanly on 19 as well.

--
With Regards,
Amit Kapila.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-08-11 03:24:45 Re: Proposal: Conflict log history table for Logical Replication
Previous Message Amit Kapila 2026-08-11 02:27:35 Re: Missing list_free in publicationcmds.c:OpenTableList