From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
---|---|
To: | Chris Bandy <bandy(dot)chris(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [PATCH] Add schema and table names to partition error |
Date: | 2020-03-20 06:50:32 |
Message-ID: | CAA4eK1+2qhYGMCq+GPY67kew-PvhQYt+u2HQee1BQtsCh7QATw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Mar 19, 2020 at 8:21 PM Chris Bandy <bandy(dot)chris(at)gmail(dot)com> wrote:
>
> On 3/18/20 11:46 PM, Amit Kapila wrote:
> > On Thu, Mar 19, 2020 at 3:55 AM Chris Bandy <bandy(dot)chris(at)gmail(dot)com> wrote:
> >>
> >>
> >> Sorry for these troubles. Attached are patches created using `git
> >> format-patch -n -v6` on master at 487e9861d0.
> >>
> >
> > No problem. I have extracted your code changes as a separate patch
> > (see attached) as I am not sure we want to add tests for these cases.
>
> Patch looks good.
>
> My last pitch to keep the tests: These would be the first and only
> automated tests that verify errtable, errtableconstraint, etc.
>
I don't object to those tests. However, I don't feel adding just for
this patch is advisable. I suggest you start a new thread for these
tests and let us see what others think about them.
--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Justin Pryzby | 2020-03-20 06:51:20 | Re: error context for vacuum to include block number |
Previous Message | Andres Freund | 2020-03-20 06:44:33 | Re: Berserk Autovacuum (let's save next Mandrill) |