| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | zengman <zengman(at)halodbtech(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Fix typo in pgstat_replslot.c |
| Date: | 2026-01-07 11:46:01 |
| Message-ID: | CAA4eK1+2fiQ+S1m4dGygTeY82LPWSQXxag3-q=UncoVbCfOF=A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 7, 2026 at 4:52 PM zengman <zengman(at)halodbtech(dot)com> wrote:
>
> I noticed this could be corrected to `exists` (instead of `exits`) here, same as commit 63ed3bc7f9a66035e0b741aaa542de35a90fe1cc.
> ```c
> /* Check if the slot exits with the given name. */
> slot = SearchNamedReplicationSlot(name, false);
>
> if (!slot)
> ereport(ERROR,
> (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> errmsg("replication slot \"%s\" does not exist",
> name)));
> ```
>
oops, we should have caught it last time along with commit
63ed3bc7f9a66035e0b741aaa542de35a90fe1cc but anyway I checked there is
no more similar typo in the code. So, the patch LGTM.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-01-07 12:01:53 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-01-07 11:45:39 | RE: Newly created replication slot may be invalidated by checkpoint |