Re: [HACKERS] logical decoding of two-phase transactions

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Ajin Cherian <itsajin(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] logical decoding of two-phase transactions
Date: 2021-03-16 13:52:47
Message-ID: CAA4eK1+0XpQRJvzOpwVtKG5cWRMqz3Ev38XBnOv0Hp=YXhKc9g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 16, 2021 at 6:22 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Mon, Mar 15, 2021 at 6:14 PM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> >
> > On Mon, Mar 15, 2021 at 2:04 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >>
>
> 2) table_states_not_ready global variable is used immediately after
> call to FetchTableStates, we can make FetchTableStates return the
> value or get it as an argument to the function and the global
> variables can be removed.
> +static List *table_states_not_ready = NIL;
>

But we do update the states in the list table_states_not_ready in
function process_syncing_tables_for_apply. So, the current arrangement
looks good to me.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2021-03-16 14:02:38 crash during cascaded foreign key update
Previous Message Amit Kapila 2021-03-16 13:45:28 Re: pg_subscription - substream column?