| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
| Subject: | Re: Allow logical replication to copy tables in binary format |
| Date: | 2023-03-09 02:50:18 |
| Message-ID: | CAA4eK1+-7S6-UyZJ6n7EqKbah0rvFp1wRUeMfe53Yibx4_HttQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 8, 2023 at 6:17 PM Melih Mutlu <m(dot)melihmutlu(at)gmail(dot)com> wrote:
>
> On 7 Mar 2023 Tue at 04:10 Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>>
>> As per what I could read in this thread, most people prefer to use the
>> existing binary option rather than inventing a new way (option) to
>> binary copy in the initial sync phase. Do you agree?
>
>
> I agree.
> What do you think about the version checks? I removed any kind of check since it’s currently a different option. Should we check publisher version before doing binary copy to ensure that the publisher node supports binary option of COPY command?
>
It is not clear to me which version check you wanted to add because we
seem to have a binary option in COPY from the time prior to logical
replication. I feel we need a publisher version 14 check as that is
where we start to support binary mode transfer in logical replication.
See the check in function libpqrcv_startstreaming().
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-03-09 02:52:20 | Re: allow_in_place_tablespaces vs. pg_basebackup |
| Previous Message | wangw.fnst@fujitsu.com | 2023-03-09 02:26:44 | RE: Support logical replication of DDLs |