Re: Small documentation improvement for ALTER SUBSCRIPTION

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small documentation improvement for ALTER SUBSCRIPTION
Date: 2021-09-14 09:57:30
Message-ID: CAA4eK1++UMnLPFrUEvv_JZ_CKeetduQqnBs-+Wu_p_-Sw4Akng@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 8, 2021 at 5:11 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Tue, Sep 7, 2021 at 9:01 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >
> > > On 7 Sep 2021, at 13:36, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> > >
> > > On 12.08.21 04:52, Masahiko Sawada wrote:
> > >> On Wed, Aug 11, 2021 at 5:42 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > >>>
> > >>>> On 11 Aug 2021, at 09:57, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >>>
> > >>>> Additionally, refresh options as described in
> > >>>> <replaceable>refresh_option</replaceable> of
> > >>>> <literal>REFRESH PUBLICATION</literal> may be specified,
> > >>>> except in the case of <literal>DROP PUBLICATION</literal>.
> > >>>
> > >>> Since this paragraph is under the literal option “refresh”, which takes a
> > >>> value, I still find your original patch to be the clearest.
> > >> Yeah, I prefer my original patch over this idea. On the other hand, I
> > >> can see the point of review comment on it that Amit pointed out[1].
> > >
> > > How about this:
> > >
> > > - Additionally, refresh options as described
> > > - under <literal>REFRESH PUBLICATION</literal> may be specified.
> > > + Additionally, the options described under <literal>REFRESH
> > > + PUBLICATION</literal> may be specified, to control the implicit refresh
> > > + operation.
> >
> > LGTM.
>
> +1
>
> Attached the patch.
>

LGTM as well. Peter E., Daniel, does any one of you is intending to
push this? If not, I can take care of this.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-09-14 10:33:15 Re: PG Docs for ALTER SUBSCRIPTION REFRESH PUBLICATION - copy_data option
Previous Message Jan Mußler 2021-09-14 09:50:59 Physical replication from x86_64 to ARM64