| From: | Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Xuneng Zhou <xunengzhou(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Subject: | Re: Optimize SnapBuildPurgeOlderTxn: use in-place compaction instead of temporary array |
| Date: | 2026-01-16 07:40:36 |
| Message-ID: | CAA3qoJn_VEBjkjw9+2yx+8Qgr41WhoTZ5sdKxZ9B9H6bBLKORA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Xuneng Zhou, Masahiko,
On Thu, Jan 15, 2026 at 6:01 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
wrote:
> On Thu, Jan 8, 2026 at 7:57 PM Xuneng Zhou <xunengzhou(at)gmail(dot)com> wrote:
> >
> > I think improving test coverage is generally beneficial and also helps
> > build familiarity with the codebase.
>
> Yes. For instance, the commit 00c3d87a5ca added the test module for
> Bitmapset, increasing the test coverage from 85.2% to 93.4%, which is
> very nice. While adding more tests is basically beneficial, we need to
> keep in mind that test execution time is also important. It would be
> great if new tests increase the test coverage and don't take a long
> time to complete.
>
>
Thank you so much for your valuable suggestions!
I totally agree that balancing test coverage and execution performance is
crucial.
I will prioritize selecting the core processes for the tests and make sure
to keep
the overall execution time in check while improving coverage.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Chen | 2026-01-16 08:09:03 | Re: nbtree: reduce code redundancy by using _bt_getmeta() in _bt_gettrueroot() |
| Previous Message | jian he | 2026-01-16 07:34:35 | Re: CREATE TABLE LIKE INCLUDING TRIGGERS |