Re: [PATCH] Align verify_heapam.c error message offset with test expectations

From: Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com>
To: zengman <zengman(at)halodbtech(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Align verify_heapam.c error message offset with test expectations
Date: 2026-01-22 02:58:19
Message-ID: CAA3qoJkdMFcVN+G9uvYtY6LM=92vyiMK9Z351TBpOoKhQM2=CA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi zengman,

On Wed, Jan 21, 2026 at 10:37 PM zengman <zengman(at)halodbtech(dot)com> wrote:

>
> This indicates that for the test case at offnum == 36, the error message
> should report "offset 43" (the successor), not "offset 36" (the current
> tuple).
> However, when I updated the test expectation from \d+ wildcard to the
> exact value offset 43, the test fails.
> This makes me wonder whether the current code in verify_heapam.c (lines
> 777, 793, 799) should be using nextoffnum instead of ctx.offnum.
>
>
Fully agreed.
I think there's no need to modify the expectations. Seems the 0002 patch
alone is sufficient.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-01-22 02:58:48 Re: file_fdw: Support multi-line HEADER option.
Previous Message Tom Lane 2026-01-22 02:39:56 Re: Remove no-op pull_var_clause flag