| From: | Neil Chen <carpenter(dot)nail(dot)cz(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: nbtree: reduce code redundancy by using _bt_getmeta() in _bt_gettrueroot() |
| Date: | 2026-01-16 08:09:03 |
| Message-ID: | CAA3qoJk3KxJ_aCwj1RHwFL53GEUHHu=szh_8j=3+GWE5JPcKUQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Chao,
On Thu, Jan 15, 2026 at 4:11 PM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
>
> I noticed this while reviewing [1]. _bt_gettrueroot() performs the same
> metapage checks as _bt_getmeta(), so using _bt_getmeta() here removes the
> duplicated code.
>
>
It looks good to me. These two code snippets are exactly identical,
so removing the redundant code is reasonable.
As can be seen from the contextual comments, this is not a
performance-critical path either,
so we don’t need to worry about the performance overhead caused by function
calls.
I also checked the changes made in commit dd299df, which essentially does
the same thing for the function _bt_getrootheight.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-01-16 08:30:50 | Re: Custom oauth validator options |
| Previous Message | Neil Chen | 2026-01-16 07:40:36 | Re: Optimize SnapBuildPurgeOlderTxn: use in-place compaction instead of temporary array |