Re: ISBN range table

From: Jonah Shafran <jonahshafran(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ISBN range table
Date: 2026-11-12 23:35:54
Message-ID: CAA2HNvS0h-DQgnmvdZPetvf0QCdYemCWU5vNhjRqgjwyO_dt3A@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Is ISBN data something that sysadmins would want to be updating out of
band? While it is certainly useful to have ISBNs formatting as expected,
there isn't a real functional impact in the same way as time zone updates.
Additionally, while I didn't look through all of them, I didn't spot other
extensions in contrib shipping data files, which makes me suspect which
makes me suspect that there are more infrastructural changes required to be
able to drive this from a text file.
Given that, my feeling is we should update the existing structure now, so
it is no longer sixteen years out of date, and then look into making the
feature more robust.

I've re-run the script and updated the patch with those changes as well as
those suggested by Florents.

On Thu, Nov 12, 2026 at 7:57 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:

> On 2026-Nov-12, Daniel Gustafsson wrote:
>
> > > On 8 Nov 2026, at 20:44, Jonah Shafran <jonahshafran(at)gmail(dot)com> wrote:
> >
> > > I came across this thread when I was looking at updating the ISBN
> table. Are you still planning to move this forward? If not would you be
> open to me pushing it forward?
> >
> > FWIW, I am also very much interested in this getting applied and
> regularly (per
> > release) maintained.
>
> One thing I wonder is why are these tables embedded in the C source
> code, where users would have a really hard time updating them, instead
> of being, like the timezone table, a separate text file or something
> that the sysadmin can update more easily.
>
> --
> Álvaro Herrera Breisgau, Deutschland —
> https://www.EnterpriseDB.com/
>

Attachment Content-Type Size
v2-0001-Update-ISBN.h-automatically.patch application/octet-stream 61.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2026-11-13 00:05:34 Re: [BUG / PATCH] PG19: VACUUM misestimates reltuples (often 0) after on-access VM setting
Previous Message Bharath Rupireddy 2026-11-12 23:33:53 Re: Vacuum statistics