Re: ISBN range table

From: Jonah Shafran <jonahshafran(at)gmail(dot)com>
To: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ISBN range table
Date: 2026-11-17 01:39:26
Message-ID: CAA2HNvQCz649q0FdcGneqNf-4E1Ct-hajfVOPfdzn-AGXe__OQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jim,
I agree with your assessment that this is unrelated to the patch- I was
able to reproduce this back to Postgres 17 (the oldest version I had
running on hand). As far as what is going on, it looks like ISSNs are
specified to use the short output format (isn_out, see isn--1.1.sql line
154), however, ISSNs don't seem to get normalized to one canonical form
when being read in by issn_in. I wasn't able to determine how ISBNs are
being handled differently with the time I had today, but it looks like
something in string2ean must be processing the ISBN and ISSN strings
differently.
Thanks,
Jonah

On Mon, Nov 16, 2026 at 2:06 PM Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> wrote:

> Hi Jonah
>
> I was playing a bit with this patch and found something odd -- most
> likely unrelated to this patch:
>
> psql (20devel)
> Type "help" for help.
>
> postgres=# create extension isn;
> CREATE EXTENSION
> postgres=# with j (v1,v2) as (
> values ('12345679'::issn, '9771234567898'::issn)
> )
> select v1,v2,v1=v2 from j;
> v1 | v2 | ?column?
> -----------+-----------+----------
> 1234-5679 | 1234-5679 | f
> (1 row)
>
> Although casting v1 and v2 display the exact same value, they compare
> unequal. I understand that the input values are "different" and
> therefore a comparison should return false, but displaying identical
> results is a bit confusing. Unless the truncation is correct, but then
> the eq operator is wrong :)
>
> Best, Jim
>
>
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2026-11-17 01:43:57 Re: pgsql: Don't trust NOT NULL on virtual generated columns of partitioned
Previous Message shihao zhong 2026-11-17 01:37:01 Re: Re: Re: Assertion failure in WAL summarizer