Re: First draft of PG 19 release notes

From: Thom Brown <thom(at)linux(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org>, chong(dot)peng(at)enmotech(dot)com
Subject: Re: First draft of PG 19 release notes
Date: 2026-05-26 15:46:12
Message-ID: CAA-aLv7w1wwucet76yAW0yq3-LrN5wL81uRrnpT3Tyxh7dmyTw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 26 May 2026 at 16:00, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> On Tue, May 26, 2026 at 01:25:15PM +0800, Chao Li wrote:
> > Chong Peng, whom I added to CC, reported this release note issue to me, so I’m just forwarding the message:
> >
> > ```
> > <listitem>
> > <para>
> > Add slot synchronization skip information to pg_stat_replication_slots (Shlok Kyal)
> > <ulink url="&commit_baseurl;76b78721c">&sect;</ulink>
> > <ulink url="&commit_baseurl;e68b6adad">&sect;</ulink>
> > <ulink url="&commit_baseurl;5db6a344a">&sect;</ulink>
> > </para>
> >
> > <para>
> > The new columns are slotsync_skip_count, slotsync_last_skip, and slotsync_skip_reason.
> > </para>
> > </listitem>
> > ```
> >
> > The feature description is inaccurate: slotsync_skip_count and slotsync_last_skip belong to pg_stat_replication_slots, while slotsync_skip_reason belongs to pg_replication_slots. Maybe it could be reworded as:
> > ```
> > Add slot synchronization skip information to pg_stat_replication_slots and pg_replication_slots (Shlok Kyal)
> > ```
>
> Yes, very good point. I missed that detail when merging the commit
> items. I fixed it as you suggested, patch attached.
>
> --
> Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
> EDB https://enterprisedb.com
>
> Do not let urgent matters crowd out time for investment in the future.

Did a review and found a few issues. Attached fixes.

Regards

Thom

Attachment Content-Type Size
release-19-fixes.patch text/x-patch 2.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Xuneng Zhou 2026-05-26 15:53:14 Re: Implement waiting for wal lsn replay: reloaded
Previous Message Tom Lane 2026-05-26 15:40:09 Re: [PATCH] Fix LISTEN startup race with direct advancement