Re: Command Triggers patch v18

On 29 March 2012 16:30, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Thu, Mar 29, 2012 at 9:01 AM, Thom Brown <thom(at)linux(dot)com> wrote:
>>> On 29 March 2012 13:30, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> wrote:
>>>> I'll go make that happen, and still need input here. We first want to
>>>> have command triggers on specific commands or ANY command, and we want
>>>> to implement 3 places from where to fire them.
>>>>
>>>> Here's a new syntax proposal to cope with that:
>>>
>>> Is it necessary to add this complexity in this version?  Can't we keep
>>> it simple but in a way that allows the addition of this later?  The
>>> testing of all these new combinations sounds like a lot of work.
>>
>> I concur.  This is way more complicated than we should be trying to do
>> in version 1.
>
> I'm at a loss here. This proposal was so that we can reach a commonly
> agreed minimal solution and design in first version. There's no new
> piece of infrastructure to add, the syntax is changed only to open the
> road for later, I'm not changing where the current command triggers are
> to be called (except for those which are misplaced).
>
> So, please help me here: what do we want to have in 9.3?

Perhaps I misunderstood. It was the addition of the fine-grained even
options (parse, execute etc) I saw as new. If you're saying those are
just possible options for later that won't be in this version, I'm
fine with that. If those are to make it for 9.2, then creating the
necessary test cases and possible fixes sounds infeasible in such a
short space of time. Please disregard if this is not the case.

--
Thom