| From: | Thom Brown <thom(at)linux(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(at)vondra(dot)me> |
| Cc: | Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kirill Reshke <reshkekirill(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Jose Arthur Benetasso Villanova <jose(dot)arthur(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Nikolay Samokhvalov <samokhvalov(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Amcheck verification of GiST and GIN |
| Date: | 2025-06-17 14:19:41 |
| Message-ID: | CAA-aLv7DVkrH2QzD0xpU8ddgQ9y=ZniQfd+XW_FhV9hRgwLk6A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 16 Jun 2025 at 21:00, Tomas Vondra <tomas(at)vondra(dot)me> wrote:
>
> On 6/16/25 21:09, Arseniy Mukhin wrote:
> > On Mon, Jun 16, 2025 at 6:58 PM Tomas Vondra <tomas(at)vondra(dot)me> wrote:
> >>
> >> Thanks.
> >>
> >> I went through the patches, polished the commit messages and did some
> >> minor tweaks in patch 0002 (to make the variable names a bit more
> >> consistent, and reduce the scope a little bit). I left it as a separate
> >> patch to make the changes clearer, but it should be merged into 0002.
> >>
> >> Please read through the commit messages, and let me know if I got some
> >> of the details wrong (or not clear enough). Otherwise I plan to start
> >> pushing this soon (~tomorrow).
> >
> > LGTM.
> > Noticed a few typos in messages:
> > in v8-0002-amcheck-Fix-checks-of-entry-order-for-GIN-indexes.patch
> > - parent key is creator
> > - as the core incorrectly expected
> > and 'Arseniy Mikhin' in some patches.
> >
>
> Thanks for noticing those typos, especially the one in the name.
Do today's commits clear this from the PostgreSQL 18 Open Items list?
Thom
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-06-17 14:21:03 | Re: Improve CRC32C performance on SSE4.2 |
| Previous Message | Andres Freund | 2025-06-17 14:17:27 | Re: Add progressive backoff to XactLockTableWait functions |