Re: pgsql: doc: Clarify CHECKPOINT handling of unlogged buffers

From: Thom Brown <thom(at)linux(dot)com>
To: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: doc: Clarify CHECKPOINT handling of unlogged buffers
Date: 2026-05-26 14:53:34
Message-ID: CAA-aLv5pZNZbdhPG2Wu0fzyKCjn9TTzN9QZ=JONPyqZQKhBV=g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, 25 May 2026 at 11:23, Daniel Gustafsson
<dgustafsson(at)postgresql(dot)org> wrote:
>
> doc: Clarify CHECKPOINT handling of unlogged buffers
>
> The CHECKPOINT reference page still described checkpoints as flushing
> all data files, which could be misleading as it depends on the value
> of FLUSH_UNLOGGED option. Update the description to make it clearer
> that only data files of permanent relations are flushed by default.
>
> Author: Chao Li <lic(at)highgo(dot)com>
> Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
> Discussion: https://postgr.es/m/4855807D-F1CA-44E6-9B58-406691832848@gmail.com
>
> Branch
> ------
> master
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/377cc45194f4f1bd6eb68bd6eb42402e46e326d7
>
> Modified Files
> --------------
> doc/src/sgml/ref/checkpoint.sgml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)

"All data for permanent relations files will be flushed to disk, dirty
buffers of unlogged relations are not flushed unless
<literal>FLUSH_UNLOGGED</literal> is specified."

This doesn't quite read right.

"permanent relations files" should be "permanent relation files"

and the sentence looks like it should end after "flushed to disk",
with "Dirty buffers" being the start of a new sentence.

Regards

Thom

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2026-05-26 14:59:51 pgsql: doc PG 19 relnotes: adjust item to mention pg_replication_slots
Previous Message Michael Paquier 2026-05-26 04:50:08 pgsql: Fix calculation of members_size in pg_get_multixact_stats()