Re: make pg_controldata accept "-D dirname"

From: Thom Brown <thom(at)linux(dot)com>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: make pg_controldata accept "-D dirname"
Date: 2014-09-24 12:57:47
Message-ID: CAA-aLv5fv4jDG2QdX2pM9Op5LQfQz9v1FwerEB4nWf9gZh1fsQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 24 September 2014 12:04, Magnus Hagander <magnus(at)hagander(dot)net> wrote:

> On Wed, Sep 24, 2014 at 12:59 PM, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>
> wrote:
> > Hi.
> >
> > I can never remember that pg_controldata takes only a dirname rather
> > than "-D dirname", and I gather I'm not the only one. Here's a tiny
> > patch to make it work either way. As far as I can see, it doesn't
> > break anything, not even if you have a data directory named "-D".
>
> I haven't looked at the code, but definitely +1 for the feature.
> That's really quite annoying.
>

And here I was thinking it was just me.

+1

Thom

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-09-24 13:02:29 Re: make pg_controldata accept "-D dirname"
Previous Message Alvaro Herrera 2014-09-24 12:54:21 Re: pg_dump bug in 9.4beta2 and HEAD