Re: pgsql: Add --section option to pg_dump and pg_restore.

From: Thom Brown <thom(at)linux(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add --section option to pg_dump and pg_restore.
Date: 2011-12-17 21:36:59
Message-ID: CAA-aLv58H5_DamJtr4xh7ng9357PagThun=FaPVuW1Xd3Jd6=A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 17 December 2011 18:11, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> On 12/17/2011 08:13 AM, Thom Brown wrote:
>>
>> On 17 December 2011 02:32, Andrew Dunstan<andrew(at)dunslane(dot)net>  wrote:
>>>
>>>
>>> On 12/16/2011 07:57 PM, Thom Brown wrote:
>>>>
>>>> On 17 December 2011 00:17, Andrew Dunstan<andrew(at)dunslane(dot)net>    wrote:
>>>>>
>>>>> Add --section option to pg_dump and pg_restore.
>>>>>
>>>>> Valid values are --pre-data, data and post-data. The option can be
>>>>> given more than once. --schema-only is equivalent to
>>>>> --section=pre-data --section=post-data. --data-only is equivalent
>>>>> to --section=data.
>>>>
>>>> "Post-data items consist of definitions of indexes, triggers, rules
>>>> and constraints other than check constraints."
>>>>
>>>> What about NOT VALID check constraints?  Those are required to be
>>>> post-data.
>>>>
>>>
>>> Hmm, yeah. Are they the only ones?
>>
>> Well, there's object permissions too excluding ownership, but can't
>> think of anything else.
>>
>
> I have qualified the sentence above to say that the exception is "validated
> check constraints".

Sounds good to me.

> The comments in the code about when ACLs are dumped or restored appear to be
> incorrect unless I'm missing something. The appear to be dumped where they
> occur. (This code always makes my head hurt, I confess.)

Dumped where they occur? I'm not sure I follow.

--
Thom

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-12-17 21:42:48 pgsql: Add SP-GiST (space-partitioned GiST) index access method.
Previous Message Andrew Dunstan 2011-12-17 18:12:34 pgsql: Same clarification for pg_restore.