Re: pgsql: Add --section option to pg_dump and pg_restore.

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Thom Brown <thom(at)linux(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add --section option to pg_dump and pg_restore.
Date: 2011-12-17 18:11:38
Message-ID: 4EECDB5A.4080000@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 12/17/2011 08:13 AM, Thom Brown wrote:
> On 17 December 2011 02:32, Andrew Dunstan<andrew(at)dunslane(dot)net> wrote:
>>
>> On 12/16/2011 07:57 PM, Thom Brown wrote:
>>> On 17 December 2011 00:17, Andrew Dunstan<andrew(at)dunslane(dot)net> wrote:
>>>> Add --section option to pg_dump and pg_restore.
>>>>
>>>> Valid values are --pre-data, data and post-data. The option can be
>>>> given more than once. --schema-only is equivalent to
>>>> --section=pre-data --section=post-data. --data-only is equivalent
>>>> to --section=data.
>>> "Post-data items consist of definitions of indexes, triggers, rules
>>> and constraints other than check constraints."
>>>
>>> What about NOT VALID check constraints? Those are required to be
>>> post-data.
>>>
>>
>> Hmm, yeah. Are they the only ones?
> Well, there's object permissions too excluding ownership, but can't
> think of anything else.
>

I have qualified the sentence above to say that the exception is
"validated check constraints".

The comments in the code about when ACLs are dumped or restored appear
to be incorrect unless I'm missing something. The appear to be dumped
where they occur. (This code always makes my head hurt, I confess.)

cheers

andrew

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2011-12-17 18:12:34 pgsql: Same clarification for pg_restore.
Previous Message Andrew Dunstan 2011-12-17 17:39:51 pgsql: Clarify the post-data status on unvalidated check constraints.