| From: | Greg Burd <greg(at)burd(dot)me> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Add tests for Bitmapset |
| Date: | 2025-09-16 12:55:59 |
| Message-ID: | CA0C373A-6857-4C4C-BF67-5C72AABA0E0D@greg.burd.me |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sep 16 2025, at 8:02 am, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Sep 16, 2025 at 2:04 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> one SQL function mapping to each C function we are testing?
>
> Yes, I think we should do this, if possible.
Michael, Robert,
Thanks for your time reviewing the proposed code and for providing
feedback. This patch started life as simply copy of the test_radixtree
module which uses a single test function triggered in SQL, hence my
approach. I guess I should have copied the test_slru module instead! :)
I see the value in the idea of splitting it up into separate functions
and I'll give that a try.
Michael, apologies for the white space issues. I'll clean that up, and
thank you for the `git diff --check` tip, I'll add that to my toolbox/routine.
> --
> Robert Haas
> EDB: http://www.enterprisedb.com
best.
-greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthias van de Meent | 2025-09-16 12:56:09 | Re: Incorrect result of bitmap heap scan. |
| Previous Message | Core Studios Inc. | 2025-09-16 12:55:49 | Re: Incorrect result of bitmap heap scan. |