| From: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
|---|---|
| To: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Generic type subscripting |
| Date: | 2017-07-05 15:05:30 |
| Message-ID: | CA+q6zcXV4Mscao_Z9ypy8rz6QfuPE+-gj2THMi5xXjvQGohFYA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 30 June 2017 at 11:34, Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> wrote:
>
> Can you rebase the patch please? It is not applyed now. I think it is
because
> of pgindent.
Sure, I've attached the rebased version of the patch.
>
> > +
> > + scratch->d.sbsref.eval_finfo = eval_finfo;
> > + scratch->d.sbsref.nested_finfo = nested_finfo;
> > +
>
> Also I have noticed that assigning eval_finfo and nested_finfo after
every time
> eval step is pushed is unnecessary in ExecInitSubscriptingRef() function.
We
> need them only for EEOP_SBSREF_OLD, EEOP_SBSREF_ASSIGN and
EEOP_SBSREF_FETCH
> steps.
I'm not sure, because an absence of any of those `eval_finfo`/`nested_finfo`
blocks in `ExecInitSubscriptingRef` breaks few tests.
| Attachment | Content-Type | Size |
|---|---|---|
| generic_type_subscription_v14.patch | text/x-patch | 216.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ryan Murphy | 2017-07-05 15:45:15 | Re: Error-like LOG when connecting with SSL for password authentication |
| Previous Message | Peter Eisentraut | 2017-07-05 14:57:24 | Re: outfuncs.c utility statement support |