From: | Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
---|---|
To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Steele <david(at)pgmasters(dot)net>, peter(dot)eisentraut(at)2ndquadrant(dot)com, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Generic type subscripting |
Date: | 2017-06-30 09:34:08 |
Message-ID: | 3939224.Pu1MPp1GC3@zakirov |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wednesday, 10 May 2017 23:43:10 MSK, Dmitry Dolgov wrote:
> So, a few words about current state of the patch:
>
> * after a lot of serious improvements general design of this feature is
> agreeable
>
> * we introduced a lot of small changes to polish it
>
> * I rebased the patch on the latest version of master, so you can take a
> look at it again
>
> As always, any feedback is welcome.
Hello,
Can you rebase the patch please? It is not applyed now. I think it is because
of pgindent.
> +
> + scratch->d.sbsref.eval_finfo = eval_finfo;
> + scratch->d.sbsref.nested_finfo = nested_finfo;
> +
Also I have noticed that assigning eval_finfo and nested_finfo after every time
eval step is pushed is unnecessary in ExecInitSubscriptingRef() function. We
need them only for EEOP_SBSREF_OLD, EEOP_SBSREF_ASSIGN and EEOP_SBSREF_FETCH
steps.
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Rafia Sabih | 2017-06-30 09:40:53 | Re: Parallel Append implementation |
Previous Message | Rafia Sabih | 2017-06-30 09:23:34 | Re: Partition-wise join for join between (declaratively) partitioned tables |