| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17928: Standby fails to decode WAL on termination of primary |
| Date: | 2023-08-14 10:28:54 |
| Message-ID: | CA+hUKGLOgGh=9siEhACUsrZEAQPVEQWgn35cggeci0_cNbPSSw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Aug 14, 2023 at 3:56 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Mon, Aug 14, 2023 at 2:08 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > It seems to me that we should try to also finish the header validation
> > before attempting XLogReadRecordAlloc() on the total_len as well? It
> > looks like the end result would be to move the first ReadPageInternal
> > done for the header with all its cross-page checks before
> > XLogReadRecordAlloc(). That should remove the need of having
> > gotheader from v1.
>
> Yeah. Trying out an idea for how to untangle that...
Something like this... patches for 12 and master attached. Needs a
lot more testing. I really want to figure out how to get
deterministic tests...
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Don-t-trust-unvalidated-xl_tot_len-v12.patch | text/x-patch | 5.5 KB |
| 0001-Don-t-trust-unvalidated-xl_tot_len-master.patch | text/x-patch | 7.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Devrim Gündüz | 2023-08-14 11:02:52 | Re: gpg error (again) |
| Previous Message | Thomas Munro | 2023-08-14 03:56:06 | Re: BUG #17928: Standby fails to decode WAL on termination of primary |