Re: BUG #17928: Standby fails to decode WAL on termination of primary

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #17928: Standby fails to decode WAL on termination of primary
Date: 2023-08-14 03:56:06
Message-ID: CA+hUKGKWPvSJkQ1De6bjV311Xk+cXU8K7a=71-ypvxJGHom5aA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Mon, Aug 14, 2023 at 2:08 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> It seems to me that we should try to also finish the header validation
> before attempting XLogReadRecordAlloc() on the total_len as well? It
> looks like the end result would be to move the first ReadPageInternal
> done for the header with all its cross-page checks before
> XLogReadRecordAlloc(). That should remove the need of having
> gotheader from v1.

Yeah. Trying out an idea for how to untangle that...

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Thomas Munro 2023-08-14 10:28:54 Re: BUG #17928: Standby fails to decode WAL on termination of primary
Previous Message Tom Lane 2023-08-14 03:27:19 Re: BUG #18054: Permission denied.