| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: stat() vs ERROR_DELETE_PENDING, round N + 1 |
| Date: | 2021-12-09 08:16:57 |
| Message-ID: | CA+hUKGL-R1v46U9LYZxZybgYvNc2WM86PtMDwGwtrXknabHevA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 6, 2021 at 9:17 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Sat, Dec 4, 2021 at 6:18 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> > I think this was broken by WIN32_LEAN_AND_MEAN (and since gained a
> > merge conflict, but that's easy to fix). I'll try to figure out the
> > right system header hacks to unbreak it...
>
> Short version: It needed <winternl.h>.
Slightly improvement: now I include <winternl.h> only from
src/port/open.c and src/port/win32ntdll.c, so I avoid the extra
include for the other ~1500 translation units. That requires a small
extra step to work, see comment in win32ntdll.h. I checked that this
still cross-compiles OK under mingw on Linux. This is the version
that I'm planning to push to master only tomorrow if there are no
objections.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Check-for-STATUS_DELETE_PENDING-on-Windows.patch | text/x-patch | 17.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-12-09 08:17:54 | Re: GUC flags |
| Previous Message | Peter Smith | 2021-12-09 08:05:18 | Re: Fix typos - "an" instead of "a" |