| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, takashi(dot)menjo(at)gmail(dot)com, Craig Ringer <craig(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, takashi(dot)menjou(dot)vg(at)hco(dot)ntt(dot)co(dot)jp |
| Subject: | Re: Remove page-read callback from XLogReaderState. |
| Date: | 2021-04-08 09:46:06 |
| Message-ID: | CA+hUKGKDDYbtZvO0kDsjg5L39kZMUksSu+byvk3HHeA5m5pypw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I squashed the patch set into one because half of them were fixups,
and the two main patches were really parts of the same change and
should go in together.
I fixed a few compiler warnings (GCC 10.2 reported several
uninitialised variables, comparisons that are always true, etc) and
some comments. You can see these in the fixup patch.
+static inline void
+XLogReaderNotifySize(XLogReaderState *state, int32 len)
I think maybe it it should really be XLogReaderSetInputData(state,
tli, data, size) in a later release. In the meantime, I changed it to
XLogReaderSetInputData(state, size), hope that name make sense...
| Attachment | Content-Type | Size |
|---|---|---|
| v20-0001-Remove-read_page-callback-from-XLogReadRecord.patch | text/x-patch | 92.5 KB |
| v20-0002-fixup.patch | text/x-patch | 13.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Suraj Kharage | 2021-04-08 09:46:26 | Re: CREATE SEQUENCE with RESTART option |
| Previous Message | Magnus Hagander | 2021-04-08 09:41:17 | Re: A new function to wait for the backend exit after termination |