| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, takashi(dot)menjo(at)gmail(dot)com, Craig Ringer <craig(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, takashi(dot)menjou(dot)vg(at)hco(dot)ntt(dot)co(dot)jp |
| Subject: | Re: Remove page-read callback from XLogReaderState. |
| Date: | 2021-04-07 22:04:26 |
| Message-ID: | CA+hUKG+Z4DDmn64z6adzAhjxdyLeVp8ce9E9_r4KcMQpezw3ZA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 7, 2021 at 8:50 PM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
> I haven't changed the name "XLog reader" to "XLog decoder". I'm doing
> that but it affects somewhat wide range of code.
Thanks for the new patch set! Let's not worry about renaming it for now.
This fails in check-world as seen on cfbot; I am not 100% sure but
this change fixes it:
@@ -1231,7 +1231,7 @@ XLogFindNextRecord(XLogFindNextRecordState *state)
{
/* Rewind the reader to the beginning of the
last record. */
state->currRecPtr = state->reader_state->ReadRecPtr;
- XLogBeginRead(state->reader_state, found);
+ XLogBeginRead(state->reader_state, state->currRecPtr);
The variable "found" seem to be useless.
I still see the 3 warnings mentioned earlier when compiling without
--enable-cassert.
There is a stray elog(HOGE) :-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2021-04-07 22:15:25 | Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view? |
| Previous Message | Tom Lane | 2021-04-07 21:58:24 | Re: psql \df choose functions by their arguments |