| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Sergei Kornilov <sk(at)zsrv(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Subject: | Re: BUG #17928: Standby fails to decode WAL on termination of primary |
| Date: | 2023-09-19 09:25:34 |
| Message-ID: | CA+hUKGK53D8OYxTQiQ9qzJsA7ymcHTqqh7V_PUM06TCT=HOJqg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Sat, Sep 16, 2023 at 6:00 PM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
> Also, I observed that "wal_log_hints = on" in extra.config, which I use via
> "TEMP_CONFIG=extra.config make check-world" makes the test fail too, though
> check-world passes fine without the new test.
> Maybe that's not an issue, and probably there are other parameters, which
> might affect this test, but I'm somewhat confused by the fact that only this
> test breaks with it.
The problem was that the Perl functions advance_XXX() would sometimes
see an "unflushed" insert position caused by hint records and other
incidental stuff, and then we'd write our contrived header at a
disconnected location after a bunch of (unwritten) zeroes. The
solution in this version is to start each test with
emit_message($node, 0), which flushes a small record.
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Don-t-trust-unvalidated-xl_tot_len.patch | text/x-patch | 25.1 KB |
| v7-0001-Don-t-trust-unvalidated-xl_tot_len.patch.16 | application/octet-stream | 25.1 KB |
| v7-0001-Don-t-trust-unvalidated-xl_tot_len.patch.15 | application/octet-stream | 24.5 KB |
| v7-0001-Don-t-trust-unvalidated-xl_tot_len.patch.14 | application/octet-stream | 22.2 KB |
| v7-0001-Don-t-trust-unvalidated-xl_tot_len.patch.13 | application/octet-stream | 22.3 KB |
| v7-0001-Don-t-trust-unvalidated-xl_tot_len.patch.12 | application/octet-stream | 22.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-09-19 09:53:14 | Re: BUG #17928: Standby fails to decode WAL on termination of primary |
| Previous Message | Jobin Augustine | 2023-09-19 08:36:41 | Re: BUG #18046: stats collection behaviour change is affecting the usability of information. |