Re: Cleaning up historical portability baggage

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Cleaning up historical portability baggage
Date: 2022-08-18 06:13:38
Message-ID: CA+hUKGJZErt=_muvi3Q3_tc=nP2=SyZtBpx_-gWYwNZOcn2_EA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 15, 2022 at 5:53 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> Remove configure probe for IPv6.
> Remove dead ifaddrs.c fallback code.
> Remove configure probe for net/if.h.
> Fix macro problem with gai_strerror on Windows.
> Remove configure probe for netinet/tcp.h.
> mstcpip.h is not missing on MinGW.

I pushed these except one, plus one more about <sys/sockio.h> which
turned out to be not needed after a bit of archeology.

Here's a slightly better AF_INET6 one. I'm planning to push it
tomorrow if there are no objections. It does something a little more
aggressive than the preceding stuff, because SUSv3 says that IPv6 is
an "option". I don't see that as an issue: it also says that various
other ubiquitous stuff we're using is optional. Of course, it would
be absurd for a new socket implementation to appear today that can't
talk to a decent chunk of the internet, and all we require here is the
headers. That optionality was relevant for the transition period a
couple of decades ago.

Attachment Content-Type Size
0001-Remove-configure-probe-for-sockaddr_in6-and-require-.patch text/x-patch 16.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2022-08-18 06:27:10 Re: shared-memory based stats collector - v70
Previous Message Justin Pryzby 2022-08-18 05:16:37 Re: shadow variables - pg15 edition