| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: shadow variables - pg15 edition |
| Date: | 2022-08-18 05:16:37 |
| Message-ID: | 20220818051637.GK26426@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 18, 2022 at 03:17:33PM +1200, David Rowley wrote:
> I'm probably not the only committer to want to run a mile when they
> see someone posting 17 or 26 patches in an email. So maybe "bang for
> buck" is a better method for getting the ball rolling here. As you
> know, I was recently bitten by local shadows in af7d270dd, so I do
> believe in the cause.
>
> What do you think?
You already fixed the shadow var introduced in master/pg16, and I sent patches
for the shadow vars added in pg15 (marked as such and presented as 001-008), so
perhaps it's okay to start with that ?
BTW, one of the remaining warnings seems to be another buglet, which I'll write
about at a later date.
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-08-18 06:13:38 | Re: Cleaning up historical portability baggage |
| Previous Message | Noah Misch | 2022-08-18 04:59:29 | Re: static libpq (and other libraries) overwritten on aix |