| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use pg_pwrite() in pg_test_fsync |
| Date: | 2021-01-24 00:50:08 |
| Message-ID: | CA+hUKGJ4VrvnD8abHx7YGkiuPwSF9UUcJQT6f-rGBuJrrKFQ1g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jan 10, 2021 at 9:21 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> I left the fsync-after-closing and non-sync'd tests using write(),
> because they weren't using lseek(). The latter case is arguably a bit
> odd because it's not overwriting pre-allocated blocks, unlike the
> earlier tests.
On closer inspection, the weird thing about that final test is that
it's opening and closing the file every time. That doesn't seem to
make any sense. Perhaps it's a copy and paste error from the previous
test? In v2 I changed it to pg_pwrite(), and moved the open and close
calls out of the loop.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Use-pg_pwrite-in-pg_test_fsync.patch | text/x-patch | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2021-01-24 00:54:22 | Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits |
| Previous Message | Andres Freund | 2021-01-24 00:36:11 | Re: [PATCH] Disable bgworkers during servers start in pg_upgrade |