Re: Parallel Full Hash Join

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Parallel Full Hash Join
Date: 2021-03-06 01:30:33
Message-ID: CA+hUKG+MDpwF2Eo2LAvzd=pOh81wUTsrwU1uAwR-v6OGBB6+7g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 2, 2021 at 11:27 PM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> On Fri, Feb 12, 2021 at 11:02 AM Melanie Plageman
> <melanieplageman(at)gmail(dot)com> wrote:
> > I just attached the diff.
>
> Squashed into one patch for the cfbot to chew on, with a few minor
> adjustments to a few comments.

I did some more minor tidying of comments and naming. It's been on my
to-do-list to update some phase names after commit 3048898e, and while
doing that I couldn't resist the opportunity to change DONE to FREE,
which somehow hurts my brain less, and makes much more obvious sense
after the bugfix in CF #3031 that splits DONE into two separate
phases. It also pairs obviously with ALLOCATE. I include a copy of
that bugix here too as 0001, because I'll likely commit that first, so
I rebased the stack of patches that way. 0002 includes the renaming I
propose (master only). Then 0003 is Melanie's patch, using the name
SCAN for the new match bit scan phase. I've attached an updated
version of my "phase diagram" finger painting, to show how it looks
with these three patches. "scan*" is new.

Attachment Content-Type Size
phj-phases-with-full-scan.png image/png 161.3 KB
v6-0001-Fix-race-condition-in-parallel-hash-join-batch-cl.patch text/x-patch 9.8 KB
v6-0002-Improve-the-naming-of-Parallel-Hash-Join-phases.patch text/x-patch 24.6 KB
v6-0003-Parallel-Hash-Full-Right-Outer-Join.patch text/x-patch 24.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-03-06 01:39:52 Re: Disallow SSL compression?
Previous Message Michael Paquier 2021-03-06 01:25:46 Re: 011_crash_recovery.pl intermittently fails